Skip to content

fix(parser): use GITHUB_TOKEN for ZIP downloads if available#1146

Merged
qin-ctx merged 1 commit intovolcengine:mainfrom
jellespijker:fix-github-token-auth
Apr 2, 2026
Merged

fix(parser): use GITHUB_TOKEN for ZIP downloads if available#1146
qin-ctx merged 1 commit intovolcengine:mainfrom
jellespijker:fix-github-token-auth

Conversation

@jellespijker
Copy link
Copy Markdown
Contributor

Description

This PR adds support for authenticating GitHub ZIP downloads using the GITHUB_TOKEN environment variable if it is available. This enables OpenViking to ingest private GitHub repositories when using the ov add-resource https://github.com/... command via the ZIP API.

Related Issue

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test update

Changes Made

  • Read GITHUB_TOKEN from environment variables in code.py's _download method.
  • Attach the token to the Authorization header when making the request to the GitHub archive API.

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested this on the following platforms:
    • Linux
    • macOS
    • Windows

Checklist

  • My code follows the project's coding style
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

Failed to generate code suggestions for PR

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 1, 2026

CLA assistant check
All committers have signed the CLA.

@jellespijker
Copy link
Copy Markdown
Contributor Author

CLA server seems to be down: I get no healthy upstream

@qin-ctx qin-ctx merged commit 8b4ffcb into volcengine:main Apr 2, 2026
2 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in OpenViking project Apr 2, 2026
@jellespijker jellespijker deleted the fix-github-token-auth branch April 2, 2026 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants